Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting block loses word #2777

Closed
wants to merge 4 commits into from

Conversation

jd-alexander
Copy link
Contributor

@jd-alexander jd-alexander commented Nov 4, 2020

Fixes #2373

When we press enter in front of swipes words, it causes the cursor to go on the new line but the text that follows is deleted. The Gutenberg PR contains a solution for this issue.

To test:
Visit this PR
PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 4, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@ceyhun
Copy link
Contributor

ceyhun commented Nov 9, 2020

Bumping the milestone to 1.42, feel free to ping me if it needs to make it to 1.41 this week.

@ceyhun ceyhun modified the milestones: 1.41, 1.42 Nov 9, 2020
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment here: WordPress/gutenberg#26701 (review)

@cameronvoell
Copy link
Contributor

Bumping the milestone to 1.43. feel free to ping me if it needs to make it to 1.42 this week.

@jd-alexander
Copy link
Contributor Author

Closed via WordPress/gutenberg#26701 (comment)

@guarani guarani mentioned this pull request Dec 8, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitting Block Before Swiped Word Loses Word
4 participants